Remove CLI from Core #791
Merged
Remove CLI from Core #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
force-pushed
the
feature/remove-cli
branch
from
097fb19
to
f68cc15
Compare
Closed
NicolasMahe
reviewed
May 25, 2019
| @@ -78,18 +76,25 @@ if [[ ! $BINCACHED ]] || [[ ! $DOCKERCACHED ]]; then | |||
| docker build -f Dockerfile.dev -t "mesg/core:$VERSION" . | |||
| fi | |||
|
|
|||
| ./bin/cli stop | |||
| # docker service rm core | |||
NicolasMahe
reviewed
May 25, 2019
There was a problem hiding this comment.
The PR is working well, but why when I ctrl+c the script ./dev-core, I get this error as last line of the output:
Error: No such service: core
Its the output of docker service rm core but only if the core doesn't exist. It feels like it's being called 2 times but I cannot debug it
|
yes can't find how to fix that but can be done in another PR if needed and anyway it's working and just for dev so it's fine to keep it like that |
NicolasMahe
previously approved these changes
May 28, 2019
|
@krhubert please also review and test ;) |
krhubert
previously approved these changes
May 29, 2019
|
Let's merge first #974 so we can have a last working CLI compatible with single-output until the js version is ready! |
|
There is a missing stuff in this PR:
|
|
Another PR to remove some scripts: #996 |
Remove circleci cli tasks
NicolasMahe
dismissed stale reviews from krhubert, ilgooz, and themself
via
421e6b8
# Conflicts: # commands/commands.go # commands/mocks/Executor.go # commands/provider/client.go # commands/provider/marketplace_provider.go # commands/provider/service_provider.go # commands/provider/wallet_provider.go # commands/service_dev.go # commands/service_dev_test.go # commands/service_execute.go
Remove cli scripts
|
@mesg-foundation/core i will force merge this PR when test are green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on another CLI separated from the core and in JS here https://github.com/mesg-foundation/cli.
So we take this decision, all the files in this PR are not necessary anymore